Changeset 234

Timestamp:

08/31/08 22:10:43 (4 months ago)

Author:

pwh

Message:

• application_helper_test.rb: Added TODOs for link_to_controller,
  device_information_box, and wrote tests for ipv4_network_name,
  generate_title_line_1, generate_title_line_2, generate_title_tag,
  test_display_snmptable_value, test_display_yn,
  test_format_interface_name, test_format_l2_interface,
  test_format_l2_interface_type, format_l3_interface and format_site.
  

• application_helper.rb: Refactored code based on 'heckle' mutation tests.
  

Files:

• nethorus/app/helpers/application_helper.rb (modified) (8 diffs)
• nethorus/test/unit/application_helper_test.rb (modified) (2 diffs)

nethorus/app/helpers/application_helper.rb

@@ -44 +44 @@
-  def format_l2_interface(address)
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-      "none"
-    else
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-    end
-
@@ -71 +75 @@
-  def format_interface_name(interface_name, description)
-
-
-
-
-
+
+
+
+
+
+
-    end
-
@@ -85 +91 @@
-  def format_site(site)
-
-if site.nil?
-"Unknown"
-els
-
-end
+# Check we've really been passed an Site object
+  
+raise "Object passed was not an Site" unless site.is_a? Sit
+
+site.description.nil? || site.description.blank?  ? "Unknown" : site.description
-
-  end
@@ -99 +105 @@
-  def format_l2_interface_type(iftype)
-
-
-
-
-
-
+
-
-  end
@@ -157 +159 @@
-      @subtitle
-
-[:action] == "index" || params[:action].match("_"
+ && (params[:action] == "index" || params[:action].match("_")
-
-      "#{params[:controller].capitalize}"
@@ -174 +176 @@
-  def device_information_box(device)
-
-
-
-
-
-
+
-
-  end
@@ -187 +185 @@
-  def display_snmptable_value(table, index, value)
-
-
+
+
+
-      return "?"
-    else
-      return table[index][value]
-    end
-
@@ -201 +199 @@
-  def display_yn(value)
-
-
-
-
-
-
+
-      return "Yes"
-    else

nethorus/test/unit/application_helper_test.rb

@@ -32 +32 @@
-  include ApplicationHelper
-
+  fixtures :devices, :ipv4_networks, :l2_interfaces, :l3_interfaces
+
+
+  # Test the link_to_controller function
+  
+  def test_link_to_controller
+
+    # TODO: Write tests for link_to_controller
+  
+  end
+
+
+  # Test the device_information_box function
+  
+  def test_device_information_box
+  
+    # TODO: Write tests for device_information_box
+  
+  end
+
+
+  # Test the ipv4_network_name function
+  
+  def test_ipv4_network_name
+  
+    assert(ipv4_network_name("10.0.0.0") == "RFC1918 network 10.0.0.0/8")
+    assert(ipv4_network_name(nil) == "Unknown")
+    assert(ipv4_network_name("255.255.255.255") == "Unknown")
+  
+  end
+  
+  
+  # Test the generate_title_line_1 function
+  
+  def test_generate_title_line_1
+
+    assert_equal "NetHorus Test", generate_title_line_1
+    
+  end
+
+
+  # Test the generate_title_line_2 function
+  
+  def test_generate_title_line_2
+
+    # TODO: Write a test for @subtitle = nil
+
+    @subtitle = "foobar"
+    assert_equal "foobar", generate_title_line_2
+    
+    @subtitle = ""
+    assert_equal "", generate_title_line_2
+
+  end
+
+
+  # Test the generate_title_tag function
+  
+  def test_generate_title_tag
+
+    @subtitle = "foobar"
+    
+    assert_equal "NetHorus Test: foobar", generate_title_tag
+  
+  end
+
+
+  # Test the display_snmptable_value function
+  
+  def test_display_snmptable_value
+  
+    table = Hash.new
+    table_data = Hash.new
+    table_data[1] = "1:1"
+    table[1] = table_data
+
+    assert(display_snmptable_value(table, 1, 1) == "1:1")
+    assert(display_snmptable_value(table, 1, 2) == "?")
+    assert(display_snmptable_value(table, 2, 2) == "?")
+    
+    assert(display_snmptable_value(table, 1, nil) == "?")
+    assert(display_snmptable_value(table, nil, 1) == "?")
+    assert(display_snmptable_value(table, nil, nil) == "?")
+
+    assert(display_snmptable_value(nil, 1, 1) == "?")
+    assert(display_snmptable_value(nil, nil, 1) == "?")
+    assert(display_snmptable_value(nil, 1, nil) == "?")
+    assert(display_snmptable_value(nil, nil, nil) == "?")
+  
+  end
+
+
+  # Test the display_yn function
+
+  def test_display_yn
+  
+    assert(display_yn(nil) == "No")
+    assert(display_yn("") == "No")
+    assert(display_yn("foobar") == "No")
+    assert(display_yn(:false) == "No")
+
+    assert(display_yn(:true) == "Yes")
+  
+  end
+
+
+  # Test the format_interface_name function
+  
+  def test_format_interface_name
+
+    assert(format_interface_name("Foo", "Bar") == "Foo (Bar)")
+    assert(format_interface_name("Foo", "") == "Foo")
+    
+    assert(format_interface_name("", "Bar") == "")
+    assert(format_interface_name("", "") == "")
+
+    assert(format_interface_name("Foo", nil) == "Foo")
+    assert(format_interface_name(nil, "Bar") == "")
+
+    assert(format_interface_name(nil, nil) == "")
+
+  end
+
+
+  # Test the format_l2_interface function
+  
+  def test_format_l2_interface
+  
+    assert(format_l2_interface("something") == "something")
+    assert(format_l2_interface("") == "none")
+    assert(format_l2_interface(nil) == "none")
+  
+  end
+  
+  
+  # Test the format_l2_interface_type function
+  
+  def test_format_l2_interface_type
+  
+    assert(format_l2_interface_type("something") == "something")
+    assert(format_l2_interface_type("") == "Unknown")
+    assert(format_l2_interface_type(nil) == "Unknown")
+  
+  end
+
+
+  # Test the format_l3_interface function
+  
+  def test_format_l3_interface
+  
+    example_interface = l2_interfaces(:test_l2interface_1)
+    assert(format_l3_interface(example_interface) == "10.0.0.1 (RFC1918 network 10.0.0.0/8)")
+
+    example_interface_without_children = l2_interfaces(:l2_interface_without_any_l3_interfaces)
+    assert(format_l3_interface(example_interface_without_children) == "none")
+  
+  end
+
-
-  # Test the variable_or_unavailable function
@@ -59 +217 @@
-  end
-
+
+  # Test the format_site function
+  
+  def test_format_site
+  
+    site = Site.new
+    assert(format_site(site) == "Unknown")
+    
+    site.description = ""
+    assert(format_site(site) == "Unknown")
+
+    site.description = "Foobar"
+    assert(format_site(site) == "Foobar")
+  
+  end
+
-end